feat: deploy from scratch scripts #1661
Conversation
ypatil12
force-pushed
the
release/destination-genesis-scripts
branch
from
0bbf516 to
4c7842c
Compare
ypatil12
force-pushed
the
feat/zeus-deploy-from-scratch
branch
from
4aaaebb to
1e9a701
Compare
|
Passing deploy script for preprod hoodi: 
|
nadir-akhtar
left a comment
nadir-akhtar
left a comment
There was a problem hiding this comment.
Didn't have the time to meticulously review the protocol-from-scratch scripts directory unfortunately, but overall LGTM. Markdown was helpful to reference against.
Seems like CI is failing for a test though. Made a note of possible cause
|
|
||
| import "./1-deployMultichainDeployer.s.sol"; | ||
| import {MultisigBuilder} from "zeus-templates/templates/MultisigBuilder.sol"; | ||
| import {IMultisig} from "script/releases/MultisigDeployLib.sol"; |
There was a problem hiding this comment.
This change seems unnecessary as this import is not used.
There was a problem hiding this comment.
Used when modifying and retrieving threshold
|
|
||
| function testScript() public virtual override { | ||
| // 1. Deploy destination chain contracts | ||
| DeployMultichainDeployer.testScript(); |
There was a problem hiding this comment.
It seems that, when the contracts are already deployed, the threshold is 3 but the parent test here checks for threshold = 1, causing CI to fail
| // ReleaseManager is not initializable | ||
| } | ||
|
|
||
| // KeyRegistrar and PermissionController are not initializable |
There was a problem hiding this comment.
nit: clean up these comments, they're a bit confusing (above we say PermissionController is initalizable)
| { | ||
| /// core/ | ||
|
|
||
| // Permission controller has no constructor |
There was a problem hiding this comment.
nit: put this in the permissions block
ypatil12
merged commit c3448b3
into
release/destination-genesis-scripts
Motivation:
We want deploy from scratch scripts for preprod-hoodi.
Modifications:
v1.6.0-protocol-from-scratchscriptMultisigDeployerLibto dedupe all the Multisig calls we were makingScripts.mdfile that describes the available scriptsResult:
Clear deploy from scratch